Conversation
Code refactoring; no functional change.
Member
|
Added a REBASE commit which added some comments. |
gperciva
approved these changes
Mar 24, 2025
Per POSIX, the shutdown(2) system call can fail with EBADF, EINVAL, ENOTSOCK, and ENOTCONN. Of these, the first three should never occur in spiped -- they indicate that we somehow got confused about file descriptors and we should terminate. ENOTCONN is harmless at this point since it indicates that a connection has been closed where we no longer wanted to send any traffic anyway. But POSIX does not prohibit other error codes from being returned; and FreeBSD returns ECONNRESET upon attempting to shutdown a closed TCP connection. Accept this as harmless as well; and treat any other errors as being fatal *for this pipe* but do not abort spiped.
cperciva
force-pushed
the
shutdown-err-handling
branch
from
c311fef to
1e0aebb
Compare
Member
Author
|
I changed the comments, but thanks for pointing out that I needed to add some. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.