Conversation
Sihun23
changed the title
parkjaehak
requested changes
Jan 26, 2025
parkjaehak
requested changes
Jan 26, 2025
src/main/java/clap/server/adapter/inbound/web/admin/RegisterMemberCsvController.java
Outdated
Show resolved
Hide resolved
parkjaehak
requested changes
Jan 26, 2025
src/main/java/clap/server/application/service/admin/RegisterMemberCsvService.java
Outdated
Show resolved
Hide resolved
joowojr
requested changes
Jan 26, 2025
src/main/java/clap/server/application/service/admin/RegisterMemberCsvService.java
Outdated
Show resolved
Hide resolved
src/main/java/clap/server/adapter/outbound/persistense/CsvParseAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/clap/server/adapter/inbound/web/admin/RegisterMemberController.java
Outdated
Show resolved
Hide resolved
Collaborator
|
추가로 PR reabse하시기전에 로컬에서 devlop 브랜치 reabse 먼저 하신 후 force push 해주시면 감사하겠습니다. |
joowojr
requested changes
Jan 31, 2025
src/main/java/clap/server/application/service/admin/CsvParseService.java
Show resolved
Hide resolved
joowojr
approved these changes
Feb 2, 2025
Contributor
joowojr
left a comment
joowojr
left a comment
There was a problem hiding this comment.
수고하셨습니다! 일단은 머지하고 추후 코드 리팩토링이 필요해보입니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
CSV 파일을 업로드하여 회원을 등록하는 registerMembersFromCsv API를 구현했습니다.
CSV 파일을 처리하는 CsvParseAdapter를 추가했습니다.
기존 RegisterMemberRequest DTO를 사용하여 데이터를 처리하며, 데이터 파싱 및 검증 과정에서 발생할 수 있는 오류를 MemberErrorCode를 통해 관리하도록 했습니다.
RegisterMemberCsvService는 파싱된 데이터를 저장하며, 성공적으로 등록된 회원 수를 반환합니다.
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
test_members.csv
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #78