Conversation
parkjaehak
approved these changes
Jan 26, 2025
hyoseong-Choi
approved these changes
Jan 26, 2025
joowojr
requested changes
Jan 26, 2025
Contributor
joowojr
left a comment
joowojr
left a comment
There was a problem hiding this comment.
수고하셨습니다. 리뷰 확인 부탁드리겠습니다!
joowojr
requested changes
Jan 31, 2025
Contributor
There was a problem hiding this comment.
Specification을 통해 조회를 구현하신 이유가 있을까요?
Collaborator
Author
There was a problem hiding this comment.
죄송합니다. QueryDSL로 바꿔서 구현하였습니다!
| @@ -56,4 +60,14 @@ public List<Member> findActiveManagers() { | |||
| public List<Member> findReviewers() { | |||
| return loadMemberPort.findReviewers(); | |||
| } | |||
Contributor
There was a problem hiding this comment.
MemberService는 재사용이 많이 되는 코드를 클래스화한 것이라 따로 애플리케이션 서비스로 분리 부탁드립니다!
Collaborator
Author
There was a problem hiding this comment.
조회 로직을 FindAllMembersService와 FindMembersWithFilterService로 분리하였습니다!
@joowojr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #80