Merged
Conversation
Collaborator
|
parkjaehak
requested changes
Jan 31, 2025
Comment on lines
37
to
48
|
|
||
| // 일반 회원일 경우 => 요청자인지 확인 | ||
| // 담당자일 경우 => 처리자인지 확인 | ||
| if ((member.getMemberInfo().getRole() == MemberRole.ROLE_MANAGER) | ||
| && !(member.getMemberId() == task.getProcessor().getMemberId())) { | ||
| throw new ApplicationException(MemberErrorCode.NOT_A_COMMENTER); | ||
| } | ||
|
|
||
| if ((member.getMemberInfo().getRole() == MemberRole.ROLE_USER) | ||
| && !(member.getMemberId() == task.getRequester().getMemberId())) { | ||
| throw new ApplicationException(MemberErrorCode.NOT_A_COMMENTER); | ||
| } |
Collaborator
There was a problem hiding this comment.
validation 같은 경우 도메인 내에 작성해주시는 것이 좀더 DDD에 가까울 것 같습니다.
hyoseong-Choi
approved these changes
Jan 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #{이슈 번호}