CLAP-201 알림 생성 logic Refactor 및 댓글 첨부파일 logic 수정#205
Merged
starboxxxx merged 3 commits intodevelopfrom Feb 2, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
알림 생성 logic을 변경하였습니다.
기존에는 eventListener를 도입하여 createTask와 알림 생성 및 푸시 알림 생성 method를 서로 분리하여 처리하도록 진행하였습니다. 그러나 이 방법 역시 동기 처리여서 createTask method가 실행되는데 많은 시간이 요구됐습니다.(알림 생성 로직이 끝날때까지 대기해야 되기 때문)
이에 따라 저는 @async를 도입하여 비동기 처리를 진행하였습니다. 또한 비동기 처리 로직 안에서도 CompletableFuture를 사용하여 병합처리를 진행하였습니다.
@joowojr 댓글 첨부파일 1개만 받을 수 있도록 수정하였습니다!
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #{이슈 번호}