Conversation
parkjaehak
reviewed
Feb 2, 2025
Comment on lines
33
to
41
| public ResponseEntity<PageResponse<AnonymousLogResponse>> getLoginAttempts( | ||
| @RequestParam(defaultValue = "0") int page, | ||
| @RequestParam(defaultValue = "20") int pageSize, | ||
| @RequestParam(defaultValue = "timestamp") String sortBy, | ||
| @RequestParam(defaultValue = "desc") String sortDirection, | ||
| @ModelAttribute FilterLogRequest anonymousLogRequest, | ||
| @AuthenticationPrincipal SecurityUserDetails userInfo) { | ||
| Pageable pageable = PageRequest.of(page, pageSize); | ||
| Pageable pageable = PageRequest.of( | ||
| page, |
Collaborator
There was a problem hiding this comment.
default value의 경우 requestAt으로 해야할 것 같습니다.
추가로 .orderBy(memberLogEntity.createdAt.desc()) 속성이 이미 설정되어있는데 pagable로 설정했을때 pagable이 적용되는지 확인해주시고 안되시면 pagable 대신 orderBy를 동적으로 적용하는 방식으로 진행하면 될 것 같습니다.
List<MemberLogEntity> result = queryFactory
.selectFrom(memberLogEntity)
.where(builder)
.leftJoin(memberLogEntity.member, memberEntity)
.orderBy(memberLogEntity.createdAt.desc())
.offset(pageable.getOffset())
.limit(pageable.getPageSize())
.fetch();
long total = queryFactory
.selectFrom(memberLogEntity)
.where(builder)
.fetch().size();
return new PageImpl<>(result, pageable, total);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
Requirements for Reviewer
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #218