Conversation
hyoseong-Choi
approved these changes
Jan 25, 2025
Collaborator
hyoseong-Choi
left a comment
There was a problem hiding this comment.
로그인 경로 외에도 모두 sessionId를 받아서 이에 대한 보안 로직을 적용할지에 대해 고민이 됩니다. -> 시간 남으면 해도 좋을 것 같아요
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 요약(Summary)
✍🏼 상세(More)
PR Desciption
로그인 실패 기록 로직 구현
로그인 실패를 관리하고 계정 잠금 상태를 확인하는 LoginAttemptFilter 구현
로그인 API 개선
Requirements for Reviewer
클라이언트와 서버간의 요청 흐름 입니다.
PR Log
새롭게 배운 것
고민 중인 사항
첨부 자료
Requirements for Reviewer
✅ 체크리스트(Checklist)
🚪 이슈 번호(Issue numbers)
Closes #59