Skip to content

[Mainline] Remove support for final fields in TagSerializer #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Goldenfield192 wants to merge 2 commits into
base: 1.12.2-forge
Choose a base branch
from
Draft

[Mainline] Remove support for final fields in TagSerializer #194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7453a2
remove support for final fields in TagSerializer
Goldenfield192 Nov 23, 2025
dcb8bb2
ref: fix exception message
Goldenfield192 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/main/java/cam72cam/mod/serialization/TagSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,7 @@ private static void init(Class<?> cls) throws SerializationException {
String fieldName = tag.value().isEmpty() ? field.getName() : tag.value();

if (Modifier.isFinal(field.getModifiers())) {
ModCore.warn("A mod is trying to deserialize a tag into a final field %s. This should never have been implemented and will be removed in future versions. You have been warned.", fieldName);
try {
Field modifiersField = Field.class.getDeclaredField("modifiers");
modifiersField.setAccessible(true);
modifiersField.setInt(field, field.getModifiers() & ~Modifier.FINAL);
} catch (NoSuchFieldException | IllegalAccessException e) {
throw new SerializationException(String.format("Unable to access field %s in class %s", fieldName, cls), e);
}
throw new SerializationException(String.format("A mod is trying to deserialize a tag into a final field %s. This should never have been implemented.", fieldName));
}

TagMapped mapped = field.getType().getAnnotation(TagMapped.class);
Expand Down