Restrict lead status changes by role and ownership#3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
canChangeLeadStatuscomputed property tofrontend/src/pages/Lead.vuethat returns true for Admin/System Manager,Sales ManagerandSales Master Manager, or for aSales Userwhendoc.owner === session.user.Dropdownonly whencanChangeLeadStatusis true and render a read-onlyButtonshowing the status otherwise.triggerStatusChangeto display an error toast and abort whencanChangeLeadStatusis false.frontend/src/pages/Lead.vue.Testing
yarn buildwhich failed in this environment due to missing local Frappe files (sites/common_site_config.jsonandfrappe/frappe/public/js/lib/posthog.js).cd frontend && yarn devto validate UI changes; the server started but runtime import resolution errors for the same missing local files were observed in this environment.Codex Task