Open
Conversation
Previously, this was using darling::export::Ok, which meant the type of `E` was unspecified. Switching to `darling::Result::Ok` is equivalent.
This makes for slightly more concise use of Accumulator::handle by removing the need to do error conversion at the call site. This is a breaking change for callers who were already calling `into` on the error path. Fixes #252
nik-rev
reviewed
Jan 16, 2026
| @@ -828,12 +828,13 @@ impl Accumulator { | |||
|
|
|||
| /// Handles a possible error. | |||
Contributor
There was a problem hiding this comment.
a more concise doc for this function could be:
/// Extracts the `Ok` value, otherwise handles the error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nik-rev @DCNick3 review is welcome
This makes for slightly more concise use of Accumulator::handle by removing the need to do error conversion at the call site.
This is a breaking change for callers who were already calling into on the error path. Two places in generated code were broken as a result of the change, so the first commit fixes those to avoid the error.
Fixes #252