Got upset about picking up archeology fragments in the mine and not being told when it's enough#108
Open
hughescr wants to merge 45 commits intoTekNoLogic:masterfrom
Open
Got upset about picking up archeology fragments in the mine and not being told when it's enough#108hughescr wants to merge 45 commits intoTekNoLogic:masterfrom
hughescr wants to merge 45 commits intoTekNoLogic:masterfrom
Conversation
…ke mission rewards
This reverts commit bcee929.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm doing a combination of guessing and reading wowprogramming for the events I'm watching; I don't know if looting archeology fragments (as opposed to digging them up) will trigger the ARTIFACT_* events. Takes a while to actually test since it involves potentially many days of mining in the garrison. Just thought I'd cover all the bases to be sure.
Also, I stuck this in the Dig.lua file instead of breaking out into a separate file or renaming Dig.lua to Archeology.lua or anything fancy. Might not be best choice.