Conversation
…rly handle it. E.g. do not try to use it without any pet or if the player already have the aura.
Support talent changes. Do not suggest it while Grimoire of Sacrifice is active.
Do not suggest to summon a demon while Grimoire of Sacrifice is active. Use IsMounted() instead of home-brew IsMountSummoned().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Here are some fixes regarding Warlocks, their pets, Soul Link and Grimoire of Sacrifice. The changes are made so Cork suggests to summon the demon pet first and them sacrifice it, and do not bother with Soul Link if the pet is dead or Grimoire of Sacrifice is active.