Conversation
wsa-wsa
force-pushed
the
fix3
branch
3 times, most recently
from
aa60883 to
3359d70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
修复scan命令的在切换数据库之后返回不在当前数据库中的内容，并添加了部分测试用例。
存在问题
1、误用全局slots，导致总是遍历不属于该kvstore的slot
2、seek查找到的是第一个大于等于该perfix的记录，但是由于type和dbid的存在，当前查找到的slot的值可能在需要查找的目标值前面，该slot上实际上是存在目标值的，不应该进行获得nextSlot操作
3、当没有查找到一个数据(即*seq==0)且*scanTimes == scanMaxTimes时，scan命令会展示无效数据被错误返回给用户
Types of Changes