Skip to content

fix bug: switching the slots and bumping the configEpoch must be executed within the same mutex lock. #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
takenliu wants to merge 1 commit into
base: 2.8.tx
Choose a base branch
from
Open

fix bug: switching the slots and bumping the configEpoch must be executed within the same mutex lock. #452

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/tendisplus/cluster/cluster_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1220,14 +1220,18 @@ Status ClusterState::setSlots(CNodePtr n,
}
++idx;
}
// NOTE(takenliu): switching the slots and bumping the configEpoch
// must be executed within the same mutex lock.
if (n == getMyselfNode()) {
Status s = clusterBumpConfigEpochWithoutConsensus();
if (!s.ok()) {
LOG(ERROR) << "setSlots BumpConfigEpoch fail";
return s;
}
}
}

if (n == getMyselfNode()) {
Status s = clusterBumpConfigEpochWithoutConsensus();
if (!s.ok()) {
LOG(ERROR) << "setSlots BumpConfigEpoch fail";
return s;
}
// NOTE(wayenchen) broadcast gossip message if meta change finished
uint64_t offset = _server->getReplManager()->replicationGetOffset();
clusterBroadcastPong(CLUSTER_BROADCAST_ALL, offset);
Expand Down