Stop displaying deleted volumes in tendrl-ui #462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugzilla: 1719033 tendrl-bug-id: Tendrl#463 Signed-off-by: GowthamShanmugasundaram <gshanmug@redhat.com>
GowthamShanmugam
force-pushed
the
1719033
branch
from
e8c711f to
67d45b8
Compare
Contributor
Author
|
@shtripat, please review |
shtripat
reviewed
Jun 19, 2019
Member
shtripat
left a comment
shtripat
left a comment
There was a problem hiding this comment.
Changes looks good. Hope you have verified the same.
@cloudbehl please check the PR once from ruby point of view once.
shtripat
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: GowthamShanmugasundaram gshanmug@redhat.com