Replace linear search in SharedPosition::AddPoint with O(1)#1872
Open
ifcquery wants to merge 7 commits intoThatOpen:mainfrom
Open
Replace linear search in SharedPosition::AddPoint with O(1)#1872ifcquery wants to merge 7 commits intoThatOpen:mainfrom
ifcquery wants to merge 7 commits intoThatOpen:mainfrom
Conversation
For 50 000 points the old linear version does ~1.25 billion comparisons; This new version does ~1-2 million operations -> 1000x+ speedup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing linear search for existing points in SharedPosition::AddPoint leads to infinite search time for some models.
The proposed change has O(1) without braking anything