Open
Conversation
DominicTWHV
suggested changes
Mar 19, 2025
DominicTWHV
left a comment
DominicTWHV
left a comment
There was a problem hiding this comment.
Some functions have an expected return typing while others do not.
Similarly, some variables have type annotations while others do not. You probably want to unify that standard.
Contributor
Author
|
I made this PR so long ago that I don't remember what I changed. I'm another person at this point, don't judge me lol But seriously, I will take a look when I have some free time, which is probably in the next six months |
|
It's probably the original repo having the same "issue". Not critical, just that nobody has looked into it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've cleaned up my previous code so it looks better (i hope)
No one else will touch it in their life anyway