Chrome version must be between 71 and 75#149
Open
alipsilv wants to merge 2 commits intoTheBrainFamily:masterfrom
Open
Chrome version must be between 71 and 75#149alipsilv wants to merge 2 commits intoTheBrainFamily:masterfrom
alipsilv wants to merge 2 commits intoTheBrainFamily:masterfrom
Conversation
Should use the latest chromedriver
Update package.json
|
Alternately, could this be merged? Same reason as the other branch- would really like to not have to go around to every dev on the team and ask them to update their node_modules, or to use a branch that may not stick around very long. |
jboydensfdc
approved these changes
Sep 6, 2019
Member
|
@iksinski @dweller23 @rcywinski please take a look at this, and #148 (comment) and figure out what should we do moving forward. Let me know if you need anything from me, but this has to be resolved next week. What do you guys do in our projects currently, to have it work? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated chromedriver to the latest version