Return the result of the callback in the promise#33
Open
georgehb wants to merge 1 commit intoTheBrainFamily:masterfrom
Open
Return the result of the callback in the promise#33georgehb wants to merge 1 commit intoTheBrainFamily:masterfrom
georgehb wants to merge 1 commit intoTheBrainFamily:masterfrom
Conversation
Closed
|
@georgehb i know it's been a while but if you are interested i merged your PR on my fork of this project: #39 (comment) |
|
I can recommend an alternative if you're interested :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the promise returned by wait-for-expect resolve to the same value returned by the supplied callback
This would allow you to do something like this without having to repeat the call to
getNumber:My motivation for this is for use in the pptr-testing-library where it's wait function is (more or less) an alias for waitForExpect. In short I often want to wait for an element to exist on the page and then do something with the element. ie what I would like to do is this