WIP: Feature/contributing file#12
Open
luca-c-xcv wants to merge 9 commits intoTheG-r-itters:developfrom
Open
Conversation
Created the contribution file to be used to explain the guidelines for completing a proper 'pull request'. Inside is a comment with a link to a github help page useful for understanding how to build the file.
created filesystem structure with README files inside the directories to keep the strucutre consistent
the python cache directories and the log files added to the new gitignore file
added a docker folder where to put all the docker files (Dockerfile and docker-compose) to create images for all the necessary services.
created a draft docker compose in which a set of networks was defined for internal and external communications and some services under development
removed the filesystem structure because it was redesigned
fixed some issue in the docker compose file and removed the docker/logger directory and files inside
Created a contribution file to explain how to create issues and how to create a patch to submit to this repository.
feed3r
requested changes
Jun 11, 2024
Contributor
feed3r
left a comment
feed3r
left a comment
There was a problem hiding this comment.
Some minor changes in spelling for the contributing guide, but a major comment about the project structure (let's include the Communications submodule)
Contributor
There was a problem hiding this comment.
Sometimes it's spelled gitAssistant (with lower g) and sometimes, especially in titles it's spelled GitAssistant (with capital G). For sure I think it should be coherent, and my preference is for GitAssistant (with capital G)
Contributor
There was a problem hiding this comment.
Same as for the docker-services. We should include the presence of submodule Communications for the Kafka infrastructure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review