Add QR Scanner #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vckttr
reviewed
Jan 9, 2025
| val inputImage = | ||
| InputImage.fromMediaImage(image, imageProxy.imageInfo.rotationDegrees) | ||
|
|
||
| scanner?.process(inputImage) |
Collaborator
There was a problem hiding this comment.
for the future
i guess the constant image processing can affect performance on low-end devices
Member
Author
There was a problem hiding this comment.
Yep - this is actually running on a separate thread (managed in the caller), and is automatically only run on the latest frame, once the previous frame is processed. So should scale fairly nicely for now.
In future, I can imagine us wanting to throttle/prioritise certain analysers over others (e.g. in Portrait mode we should heavily prioritise segmentation and blurring, but less so qr scanning)
A future problem!
ISNIT0
force-pushed
the
ISNIT0/qr-scanner
branch
5 times, most recently
from
ef40700 to
15b69fb
Compare
…get the box rendering properly)
ISNIT0
force-pushed
the
ISNIT0/qr-scanner
branch
from
a777a97 to
0355732
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bare-bones QR Code scanner.
Modified the plugin renderers slightly so they can render on multiple surfaces at once.