Run lintr over the project and amend code presentation accordingly#126
Open
francisbarton wants to merge 16 commits intomainfrom
Open
Run lintr over the project and amend code presentation accordingly#126francisbarton wants to merge 16 commits intomainfrom
francisbarton wants to merge 16 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed by this pull-request: Internal: Run
lintrover the project and amend code presentation accordingly #125Changes proposed in this PR:
{}where covering more than 1 linepick()orif_any()etc.# nolintcomment used where line lengths cannot currently be further shortened or to avoid object not used warnings fromlintr(several R objects are created in order to be referred to in the report .Rmd file, but are not further referred to within the current R function)all_of()to wrap named column names - these were introduced by me in the first place :-/Please confirm that you have:
devtools::test()and fixed all failing tests and warnings.suppressMessages()to any test message which breaks the test progress UI.R CMD check also passes. Documentation (.Rd files) has been regenerated.
Version bumped in DESCRIPTION.