fix: respect tmux base-index and pane-base-index settings#140
Open
noqcks wants to merge 1 commit intoTinyAGI:mainfrom
Open
fix: respect tmux base-index and pane-base-index settings#140noqcks wants to merge 1 commit intoTinyAGI:mainfrom
noqcks wants to merge 1 commit intoTinyAGI:mainfrom
Conversation
The daemon hardcoded window index 0 and pane indices starting at 0 when targeting tmux panes. Users with `set -g base-index 1` or `set -g pane-base-index 1` in their tmux.conf would see "can't find window: 0" errors, causing all channel processes, queue processor, and heartbeat to silently fail to start despite the session being created. Detect the actual base indices at runtime so pane targeting works regardless of the user's tmux configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0and pane indices starting at0when targeting tmux panesset -g base-index 1orset -g pane-base-index 1in tmux.conf see silent failures: all channel processes, queue processor, and heartbeat fail to startsend-keyscommands produce "can't find window: 0" errors, making it look like everything started when nothing didFix
Detect
base-indexandpane-base-indexat runtime viatmux show-option -gvand use them when targeting panes, instead of hardcoding0.Test plan
base-index 1andpane-base-index 1— all panes start correctly