Conversation
WalkthroughThe changes introduce enhanced type safety and nullability annotations for entity metadata handling in the codebase. Method signatures and field types are updated to use parameterized generics and explicit nullability, while several dependency versions are updated in the build configuration. No control flow or logic is altered. Changes
Poem
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
api/src/main/java/me/tofaa/entitylib/meta/EntityMeta.java (1)
274-282: ParameterclientVersionremains unused – consider pruning or wiring it in.The method now advertises non-nullability and generic safety (👍), but it still ignores the supplied
ClientVersion, returning the same list for every call. Either document the intentional no-op or route the version through toMetadataso callers get version-specific data in the future.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
api/src/main/java/me/tofaa/entitylib/meta/EntityMeta.java(1 hunks)api/src/main/java/me/tofaa/entitylib/meta/Metadata.java(5 hunks)libs.versions.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
libs.versions.toml (1)
2-5: Double-check downstream compatibility for the four bumped libraries.All four updates are minor/patch releases, but they still carry API surface changes (e.g., Adventure 4.22 adds new
ComponentLikehelpers, PacketEvents ≥ 2.9 bumps some enum names). Please re-run the full integration test suite on the lowest and highest Minecraft server versions you support to ensure no runtime regressions slip in.api/src/main/java/me/tofaa/entitylib/meta/EntityMeta.java (1)
279-282: Generic wildcard migration looks good.
The override now matches the updatedMetadata#getEntries()signature and keeps the list immutable, eliminating raw-type warnings.api/src/main/java/me/tofaa/entitylib/meta/Metadata.java (1)
108-110: Return type now fully parameterised – nice cleanup.
The unchecked warning suppression is still required forgetIndex, but the public API is now type-safe.
|
lgtm! |
…adata
Summary by CodeRabbit
Chores
Refactor