Skip to content

feat(meta): add TntMeta class and register in MetaConverterRegistry#38

Merged
Tofaa2 merged 4 commits intoTofaa2:masterfrom
fantasyorg:master
Jul 20, 2025
Merged

feat(meta): add TntMeta class and register in MetaConverterRegistry#38
Tofaa2 merged 4 commits intoTofaa2:masterfrom
fantasyorg:master

Conversation

@felipepasc
Copy link
Contributor

@felipepasc felipepasc commented Jul 20, 2025

Summary by CodeRabbit

  • New Features
    • Added support for TNT entity metadata, including fuse time and block data handling.

@coderabbitai
Copy link

coderabbitai bot commented Jul 20, 2025

Walkthrough

The changes add a new TntMeta class to handle TNT entity metadata and update the MetaConverterRegistry to register this new converter. No other modifications to logic, error handling, or public API signatures were made.

Changes

File(s) Change Summary
.../meta/MetaConverterRegistry.java Added TNT entity meta converter registration before TNT_MINECART
.../meta/other/TntMeta.java Added new TntMeta class with fuse time and block data methods

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant MetaConverterRegistry
    participant TntMeta

    Client->>MetaConverterRegistry: Initialize
    MetaConverterRegistry->>TntMeta: Register TNT meta converter
    Client->>TntMeta: Create TntMeta(entityId, metadata)
    TntMeta->>TntMeta: getFuseTime() / setFuseTime(value)
    TntMeta->>TntMeta: getBlockData() / setBlockData(value)
Loading

Poem

A spark for TNT, a meta anew,
Registry lines shuffled, with changes in view.
Fuse times and block states, now easy to see,
Entity magic, as simple as can be!
Boom goes the code—rabbits cheer with glee! 🐇💥


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d69eeb3 and 3d803fd.

📒 Files selected for processing (1)
  • api/src/main/java/me/tofaa/entitylib/meta/MetaConverterRegistry.java (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • api/src/main/java/me/tofaa/entitylib/meta/MetaConverterRegistry.java
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Tofaa2
Copy link
Owner

Tofaa2 commented Jul 20, 2025

What was the reason for removing creeking and enderpearl etc from the registry

@felipepasc
Copy link
Contributor Author

What was the reason for removing creeking and enderpearl etc from the registry

I took it by accident, I'll fix it now

```
- Implemented converters for ALLAY, CREAKING, ENDER_PEARL,
  EVOKER_FANGS, GHAST, HAPPY_GHAST, ITEM, MOOSHROOM, PHANTOM,
  POTION, SNOWBALL, and SQUID.
- Verified and updated converters for COW, and added TODO notes
  for correctness checks on certain entities.
```
@felipepasc
Copy link
Contributor Author

@Tofaa2 fixed

@Tofaa2
Copy link
Owner

Tofaa2 commented Jul 20, 2025

LGTM! Thank you!

@Tofaa2 Tofaa2 merged commit 9dec137 into Tofaa2:master Jul 20, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants