Ensure InputStream and BufferedReader are closed properly

[neziw]

Replaces manual closing of InputStreamReader and BufferedReader with try-with-resources for safer and cleaner resource management in the getLatestReleaseVersion method.

This fixes potencial resources leak that might happen in certain situations.

Summary by CodeRabbit

• Refactor
  • Improved resource management when checking for the latest version from GitHub, resulting in more robust error handling.

[coderabbitai]

Walkthrough

The getLatestVersion() method in GithubUpdater.java was refactored to utilize a try-with-resources block for automatic resource management of readers. The exception handling for missing "tag_name" in the JSON response was also moved inside the try block, with an explicit IOException thrown if the field is absent.

Changes

Cohort / File(s)	Change Summary
GithubUpdater Refactor api/.../GithubUpdater.java	Refactored getLatestVersion() to use try-with-resources for readers; moved missing "tag_name" exception handling inside the try block.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hopped through lines of code,
Tidying streams where data flowed.
With try-with-resources, neat and bright,
No leaks in memory, all is right.
Now fetching tags from GitHub’s den,
The code is crisp—let’s merge again! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f9b2afd and d706e28.

📒 Files selected for processing (1)

• api/src/main/java/me/tofaa/entitylib/utils/GithubUpdater.java (1 hunks)

🔇 Additional comments (3)

api/src/main/java/me/tofaa/entitylib/utils/GithubUpdater.java (3)

61-64: Excellent use of try-with-resources for automatic resource management.

The implementation correctly uses try-with-resources to ensure both InputStreamReader and BufferedReader are automatically closed, eliminating the risk of resource leaks that could occur with manual resource management.

---

65-66: JSON parsing logic remains correct.

The response reading and JSON parsing implementation is appropriate for the GitHub API integration.

---

68-71: Good placement of exception handling within try block.

Moving the "tag_name" validation inside the try-with-resources block ensures that resources are properly closed even when this exception is thrown. The error message is descriptive and helps with debugging.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.