Skip to content

Handle website workflows#460

Merged
Behzad-rabiei merged 2 commits intomainfrom
handle-website-workflows
Apr 8, 2025
Merged

Handle website workflows#460
Behzad-rabiei merged 2 commits intomainfrom
handle-website-workflows

Conversation

@Behzad-rabiei
Copy link
Member

@Behzad-rabiei Behzad-rabiei commented Apr 8, 2025

Summary by CodeRabbit

  • New Features
    • Enhanced website management: When website schedules are updated or deactivated, background workflows are now automatically terminated for a cleaner, more efficient process.

@coderabbitai
Copy link

coderabbitai bot commented Apr 8, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes address formatting improvements and workflow termination enhancements. The controller file now has consolidated and reformatted import statements for better readability. In the service files, debug console logs have been removed and additional asynchronous calls have been introduced to terminate website workflows when certain conditions are met. New methods have been added in both the temporal and website service layers, enabling programmatic termination of workflows. No modifications were made to the public or exported entities.

Changes

File(s) Change Summary
src/controllers/platform.controller.ts Reformatted import statements: consolidated third-party libraries into a single line and listed service modules vertically for clarity.
src/services/module.service.ts
src/services/platform.service.ts
src/services/temporal/website.service.ts
src/services/website/core.service.ts
Removed extraneous console logs; added asynchronous calls to terminate website workflows; introduced new methods (terminateWorkflow and terminateWebsiteWorkflow) to enhance workflow cleanup.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as Module/Platform Service
    participant Core as Website Core Service
    participant Temporal as TemporalWebsiteService

    Caller->>Core: terminateWebsiteWorkflow(workflowId)
    Core->>Temporal: terminateWorkflow(workflowId)
    Temporal-->>Core: Workflow terminated
    Core-->>Caller: Termination successful
Loading

Suggested Reviewers

  • cyri113

Poem

I'm a hopping rabbit with a joyful code sway,
Import lines prance neatly in a brand new way.
No more debug chatter in the midnight logs,
Workflows now terminate like disappearing fogs.
Hopping on with clear paths and bytes at play!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b7c7546 and 8a6bcb6.

📒 Files selected for processing (5)
  • src/controllers/platform.controller.ts (1 hunks)
  • src/services/module.service.ts (2 hunks)
  • src/services/platform.service.ts (1 hunks)
  • src/services/temporal/website.service.ts (1 hunks)
  • src/services/website/core.service.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Behzad-rabiei Behzad-rabiei merged commit 2539846 into main Apr 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant