fix: fix terminate bugs

[Behzad-rabiei]

Summary by CodeRabbit

• Refactor

  • Adjusted website resource management so that, when resource changes occur, associated workflows are terminated appropriately while schedule information is updated.

• Chores

  • Enhanced logging during workflow termination to improve operational monitoring and insights.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request modifies two service files. In the platform service, the cleanup and resource change functions now call the website workflow termination function and comment out the previous schedule deletion, nullifying the schedule ID in the metadata. In the temporal website service, logging in the workflow termination method has been enhanced while a logging statement in the schedule creation method is removed.

Changes

File Path	Change Summary
src/services/platform.service.ts	Modified handlePlatformCleanup to call terminateWebsiteWorkflow when the platform is "Website" with a schedule; in handleWebsiteResourceChanges, commented out schedule deletion and set updateBody.metadata.scheduleId to null.
src/services/temporal/website.service.ts	Added logging in terminateWorkflow to record the workflowId and the client handle; removed a logging statement that previously output the type of platformId in createSchedule.

Sequence Diagram(s)

sequenceDiagram
    participant PS as Platform Service
    participant WS as Website Service (Core)
    Note over PS: In handlePlatformCleanup, for "Website" with scheduleId
    PS->>WS: terminateWebsiteWorkflow(scheduleId)
    WS-->>PS: Workflow termination acknowledgment
    Note over PS: Set updateBody.metadata.scheduleId to null

Loading

sequenceDiagram
    participant TWS as Temporal Website Service
    Note over TWS: In terminateWorkflow method
    TWS->>TWS: Log workflowId being terminated
    TWS->>TWS: Log client handle from workflow termination
    TWS-->>Caller: Return termination result

Loading

Possibly related PRs

• debug: check the flow #452: Focuses on logging within the handleWebsiteResourceChanges function, making it related to the modifications in this PR.
• delete temporal schedule for discourse. #412: Involves changes to the deletePlatform function with schedule deletion logic, which connects to the schedule handling changes in this PR.
• Handle website workflows #451: Addresses modifications in handlePlatformCleanup and handleWebsiteResourceChanges, directly interfacing with the terminateWebsiteWorkflow method.

Poem

Oh, what a hop this change has been,
Schedules calm and workflows serene.
I nibble on carrots and code with delight,
Logging and terminations now feel just right.
A bunny’s cheer for code so bright!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2539846 and 2367c76.

📒 Files selected for processing (2)

• src/services/platform.service.ts (2 hunks)
• src/services/temporal/website.service.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.