fix: check if workflow is stop already

[Behzad-rabiei]

Summary by CodeRabbit

• Bug Fixes
  • Improved the workflow termination process by adding a status verification step, ensuring termination commands are executed only when necessary. This enhancement helps prevent unnecessary actions, contributing to more reliable and efficient operations.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the terminateWorkflow method in the TemporalWebsiteService class. The method now retrieves the workflow description via handle.describe(), logs this description, and then checks if the workflow's status is 'TERMINATED' before calling the terminate method. This update introduces a conditional check to control the termination process.

Changes

File	Change Summary
src/.../website.service.ts	Modified terminateWorkflow to retrieve and log the workflow description. Added a conditional check that calls terminate only if the status is 'TERMINATED'.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant WS as TemporalWebsiteService
    participant Handle as Workflow Handle

    Client->>WS: terminateWorkflow()
    WS->>Handle: describe()
    Handle-->>WS: workflow description
    WS->>WS: Log description
    alt Status == 'TERMINATED'
        WS->>Handle: terminate()
        Handle-->>WS: termination confirmation
    else
        WS-->>Client: No termination call made
    end
    WS-->>Client: Return response

Loading

Poem

I’m a bunny with joyous beats,
Hopping through code with nimble feats.
Logging workflow tales all night,
Terminating only when things are right.
Cheers to changes—hop, skip, and delight! 🐇🎉

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12f9149 and e879fee.

📒 Files selected for processing (1)

• src/services/temporal/website.service.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.