fix: fix workflow id

[Behzad-rabiei]

Summary by CodeRabbit

• Refactor
  • Enhanced our website workflow termination process to now rely on community-specific identifiers, delivering more precise and consistent handling of workflow shutdowns while maintaining robust error monitoring.

[coderabbitai]

Walkthrough

The change updates the terminateWebsiteWorkflow function in the website core service. The function’s parameter has been renamed from workflowId to communityId. In addition, the termination call now constructs a community-specific identifier using the communityId parameter in the format website:ingestor:${communityId}. The error handling and logging mechanisms remain unchanged.

Changes

File	Change Summary
src/services/website/core.service.ts	Renamed parameter from workflowId to communityId. Updated the internal call to temporalWebsite.terminateWorkflow to use website:ingestor:${communityId} instead of a generic ID. Error handling remains the same.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant WebsiteService
    participant TemporalWebsite

    Caller->>WebsiteService: terminateWebsiteWorkflow(communityId)
    WebsiteService->>TemporalWebsite: terminateWorkflow("website:ingestor:" + communityId)
    TemporalWebsite-->>WebsiteService: Success/Error Response
    WebsiteService-->>Caller: Final Response/Error

Loading

Poem

I'm a rabbit with a coder's knack,
Hopping through code with a shiny new track.
Changed a name and tweaked a string,
Community flair makes the workflow sing.
Bye-bye old ID, hello to the new!
🐰✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/services/website/core.service.ts (1)

30-33: Improved parameter naming and workflow identification strategy.

The change from workflowId to communityId makes the function's purpose clearer, while constructing the workflow ID with a consistent format (website:ingestor:${communityId}) ensures reliable workflow identification. This is a good fix that likely resolves issues with workflow termination.

Consider adding a brief comment explaining this ID format to improve maintainability:

 async function terminateWebsiteWorkflow(communityId: string): Promise<void> {
   try {
+    // Format: website:ingestor:{communityId} is the convention for identifying community-specific website workflows
     await temporalWebsite.terminateWorkflow(`website:ingestor:${communityId}`);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0196ba and 39dd122.

📒 Files selected for processing (1)

• src/services/website/core.service.ts (1 hunks)