fix: fix workflow id

[Behzad-rabiei]

Summary by CodeRabbit

• Bug Fixes
  • Revised the handling of website schedule deletions to ensure that outdated schedules are properly removed from the system.
  • Improved termination procedures for background operations linked to schedule removals by refining conditions for clean-up, promoting more stable service performance.
  • These updates enhance overall system reliability and offer a smoother process for managing website scheduling workflows.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the logic for handling website schedule deletion. In the platform service, a previously commented-out deletion call is now active, ensuring that when a schedule identifier is present, the schedule is removed. In the temporal website service, the termination logic is modified by removing logging statements and changing the condition to terminate a workflow only if its state is neither terminated nor completed, while also adding a deletion call within the schedule deletion method.

Changes

File(s)	Change Summary
src/.../platform.service.ts	In handleWebsiteResourceChanges, the previously commented deletion of the website schedule has been activated. The function now actively deletes the schedule when an ID exists and then clears the metadata.
src/.../temporal/website.service.ts	In TemporalWebsiteService, the terminateWorkflow method now omits logging and modifies the condition to only terminate workflows not already terminated or completed. Additionally, deleteSchedule now includes a call to await handle.delete();.

Sequence Diagram(s)

sequenceDiagram
    participant PS as Platform Service
    participant CS as Core Service
    participant TWS as Temporal Website Service
    participant WH as Workflow Handle

    PS->>CS: deleteWebsiteSchedule(scheduleId)
    CS->>TWS: Request schedule deletion
    TWS->>WH: Execute handle.delete()
    CS->>TWS: Request workflow termination
    TWS->>WH: If workflow not TERMINATED/COMPLETED, execute handle.terminate("Terminated due to schedule deletion")

Loading

Poem

Oh, how my hops skip with delight,
Code is clearer, shining bright.
Schedules vanish with a nimble call,
Workflows rest, no errors at all.
A rabbit's cheer in every byte—
Hoppin' through code, day and night!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 362f2cd and ba9d163.

📒 Files selected for processing (2)

• src/services/platform.service.ts (1 hunks)
• src/services/temporal/website.service.ts (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.