fix: add metadata to encode

[Behzad-rabiei]

Summary by CodeRabbit

• Bug Fixes
  • Improved metadata handling in attestation generation
  • Enhanced error logging for attestation retrieval

[coderabbitai]

Walkthrough

The pull request introduces modifications to the EasService class in the eas.service.ts file. The changes focus on two key areas: improving the metadata handling in the getSignedDelegatedAttestation method and enhancing error logging in the getAttestaion method. The updates aim to ensure more accurate metadata inclusion in attestation payloads and provide more precise error messages for better debugging and traceability.

Changes

File	Change Summary
src/eas/eas.service.ts	- Updated getSignedDelegatedAttestation to use actual metadata from anyJwtPayload - Improved error logging in getAttestaion method to provide more specific error context

Possibly related PRs

• fix: fix the bugs #24: Changes to getSignedDelegatedAttestation method's data construction and formatting
• fix: fix the bugs #25: Logging enhancements in the EasService class for improved debugging

Poem

🐰 In the realm of bytes and code so bright,
Metadata now dances with delight!
Errors whisper secrets clear and true,
A rabbit's patch, debugging breakthrough!
Hop, hop, hooray for clearer sight! 🔍

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/eas/eas.service.ts (1)

172-172: LGTM! Consider extracting the metadata fallback logic.

The metadata handling is now consistent with its usage in hash generation and encryption. However, to improve maintainability and reduce potential inconsistencies, consider extracting the metadata fallback logic into a helper method.

+  private getMetadataWithFallback(metadata: unknown): object {
+    return metadata || {};
+  }

   async getSignedDelegatedAttestation(
     signDelegatedAttestationDto: SignDelegatedAttestationDto
   ) {
     // ...
     const key = generateHash(
       anyJwtPayload.sub,
       anyJwtPayload.provider,
-      anyJwtPayload.metadata || {}
+      this.getMetadataWithFallback(anyJwtPayload.metadata)
     );
     const secret = await this.litService.encryptToJson(
       chainId,
       {
         id: anyJwtPayload.sub,
         provider: anyJwtPayload.provider,
-        metadata: anyJwtPayload.metadata || {},
+        metadata: this.getMetadataWithFallback(anyJwtPayload.metadata),
       },
       key,
       siweJwtPayload.sub as '0x${string}'
     );
     // ...
     const encodedData = this.encodeAttestationData([
       key,
       anyJwtPayload.provider,
       secret,
-      JSON.stringify(anyJwtPayload.metadata || {}, null, 0),
+      JSON.stringify(this.getMetadataWithFallback(anyJwtPayload.metadata), null, 0),
     ]);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 287412f and 9af58b0.

📒 Files selected for processing (1)

• src/eas/eas.service.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Lint