Skip to content

General Catchall For Bad Commands #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
opensourcejunkie wants to merge 2 commits into
base: master
Choose a base branch
from
Open

General Catchall For Bad Commands #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed7c52c
Committing partial fix to receipt of invalid telnet commands. Fix ne…
opensourcejunkie Jul 9, 2013
73ce974
Fixing style issue - tabs to spaces
opensourcejunkie Jul 9, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion lib/telnet.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ function parseCommand (bufs, i, event) {
var command = bufs.get(i)
event.commandCode = command
event.command = COMMAND_NAMES[command]
if (event.command === undefined) {
throw "Unsupported command received: " + command;
}
return COMMAND_IMPLS[command](bufs, i + 1, event)
}

Expand Down Expand Up @@ -198,7 +201,15 @@ function Socket (input, output) {
var data = bufs.splice(0, i).toBuffer()
self.emit('data', data)
}
i = parse(bufs)
try {
i = parse(bufs);
} catch (e) {
console.log(e);
break; // somehow handle the error. break hangs the entire server; I'm
// guessing that the ctr+c is still in the buffer, and needs to
// be removed. Very new to node, however, so perhaps someone else
// will know how to do that.
}
if (i === MORE) {
debug('need to wait for more...')
break
Expand Down