Skip to content

Comments

feat: adapt to v0#13

Closed
null8626 wants to merge 10 commits intoTop-gg-Community:masterfrom
null8626:split/v0
Closed

feat: adapt to v0#13
null8626 wants to merge 10 commits intoTop-gg-Community:masterfrom
null8626:split/v0

Conversation

@null8626
Copy link
Member

The following pull request is a toned down version of #12. This pull request focuses solely on the changes done to the SDK in the v0 of the API. Such as:

  • Adapting the SDK to newer changes in v0 like reviews.
  • Other refactors to make the code easier to read and maintain.
  • Updating the LICENSE.
  • Updating the required go version to 1.21 to be able to use the min function.
  • Distinguishing webhooks from other aspects of the SDK.

@velddev
Copy link

velddev commented Sep 17, 2025

Could we avoid renaming the public API? I understand it would make things more clear and direct but a lot of clients already support the V0 API and there's no value for us to apply a breaking change on the v0 api as it is not being updated anymore.

Updating the required go version to 1.21 to be able to use the min function.

Doesn't feel like that's really worth losing the compatibility for older clients.

@velddev velddev mentioned this pull request Sep 17, 2025
@null8626
Copy link
Member Author

Right, my bad.

@null8626
Copy link
Member Author

null8626 commented Sep 18, 2025

Almost every breaking change is reverted. The only breaking change is getVotes, as it now accepts a page argument now instead of a botID argument.

Adding the latter or removing the former would be breaking nonetheless (as Go does not support optional parameters or function overloading), so the parameter is replaced.

null8626 added a commit to null8626/go-sdk that referenced this pull request Sep 18, 2025
@null8626
Copy link
Member Author

It has been tested with go test.

@null8626
Copy link
Member Author

null8626 commented Sep 19, 2025

Since Go does not support optional parameters, many legacy function parameters in here will be left unused. Feel free to let me know if you want for these function parameters to be removed as well.

@null8626
Copy link
Member Author

Most breaking changes reverted.

@null8626
Copy link
Member Author

null8626 commented Feb 5, 2026

Closed in anticipation of a major update that adds v1 support but deletes all v0 features.

@null8626 null8626 closed this Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants