Open
Conversation
Owner
|
will review and test ASAP |
Owner
|
@1337Crakker how can i get in touch with you? discord/telegram or anything? |
Author
|
Addressed all issues in the fix commit. I couldn't reproduce stars flashing bug so I hope it's fixed :P |
Author
|
Author
|
When other player causes an explosion the game was attributing that crime to the local player, giving them stars they didn't earn. This commit fixes this, so the game doesn't blame you for someone else's explosions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Syncs wanted levels across all connected players using a shared max approach - the highest wanted level among all players is applied to everyone.
How it works
Each player tracks their own wanted level separately. When it changes (crimes, bribes, death), the update is sent to the server and relayed to all clients. Each client computes
max(own level, all remote levels)and writes it directly toCWanted::m_nWantedLevel(avoidsSetWantedLevelNoDropwhich pollutes chaos level and causes stars to persist after death).Tested scenarios