TOURCMS-11047 Type methods parameters and returns, use consts and imp… #107

palisis-armando · 2025-05-09T12:22:26Z

…rove code

palisis-juanra

@armando-palisis great job.
There are just a few issues, which should be resolved.
This is mainly because PR has been created and dev branch has not been updated against latest version surely

src/TourCMS.php

… remove isXMLObject method

src/TourCMS.php

palisis-juanra · 2025-05-15T07:26:55Z

src/TourCMS.php

+     * @author Francisco Martinez Ramos
+     * @return bool
+     */
+    public function set_user_agent(string $user_agent, bool $prepend = true): bool


Suggested change

public function set_user_agent(string $user_agent, bool $prepend = true): bool

public function set_user_agent(string $userAgent, bool $prepend = true): bool

palisis-juanra · 2025-05-15T07:27:45Z

src/TourCMS.php

+    }

-	public function search_tours($params = "", $channel = 0) {
+    public function update_tour($tour_data, int $channel): SimpleXMLElement|string


Suggested change

public function update_tour($tour_data, int $channel): SimpleXMLElement|string

public function update_tour(SimpleXMLElement $tour, int $channel): SimpleXMLElement|string

palisis-juanra · 2025-05-15T07:28:02Z

src/TourCMS.php

-	public function search_tours($params = "", $channel = 0) {
+    public function update_tour($tour_data, int $channel): SimpleXMLElement|string
+    {
+        return $this->request(self::PATH_API_TOUR_UPDATE, $channel, self::HTTP_VERB_POST, $tour_data);


Suggested change

return $this->request(self::PATH_API_TOUR_UPDATE, $channel, self::HTTP_VERB_POST, $tour_data);

return $this->request(self::PATH_API_TOUR_UPDATE, $channel, self::HTTP_VERB_POST, $tour);

palisis-juanra · 2025-05-15T07:32:22Z

src/TourCMS.php

+    public function create_channel(SimpleXMLElement|string $channel_info, int $channel): SimpleXMLElement|string
+    {
+        return $this->request(self::PATH_API_CHANNEL_CREATE, $channel, self::HTTP_VERB_POST, $channel_info);
+    }


Suggested change

public function create_channel(SimpleXMLElement|string $channel_info, int $channel): SimpleXMLElement|string

{

return $this->request(self::PATH_API_CHANNEL_CREATE, $channel, self::HTTP_VERB_POST, $channel_info);

}

public function create_channel(SimpleXMLElement|string $newChannel, int $channel): SimpleXMLElement|string

{

return $this->request(self::PATH_API_CHANNEL_CREATE, $channel, self::HTTP_VERB_POST, $newChannel);

}

…lidation of tourId

belen-palisis · 2025-05-22T05:59:51Z

src/TourCMS.php

+
+    public function search_voucher(SimpleXMLElement|string|null $voucherData = null, $channel = 0): SimpleXMLElement
+    {
+


Extra line here

belen-palisis · 2025-05-22T06:02:44Z

src/TourCMS.php

+
+    public function add_note_to_booking(int $bookingId, int $channel, string $text, string $noteType): SimpleXMLElement
+    {
+


Extra line here

belen-palisis · 2025-05-22T06:04:58Z

src/TourCMS.php

+    }
+
+    public function verify_customer(SimpleXMLElement|string $customer, int $channel): SimpleXMLElement
+	{


Suggested change

{

{

belen-palisis · 2025-05-22T06:05:14Z

src/TourCMS.php

+    public function verify_customer(SimpleXMLElement|string $customer, int $channel): SimpleXMLElement
+	{
+		return $this->request(self::PATH_API_CUSTOMER_VERIFICATION, $channel, self::HTTP_VERB_POST, $customer);
+	}


Suggested change

}

}

belen-palisis

Great job! Only a few linter issues.

palisis-juanra

great job @armando-palisis just a few tweaks to validate tour id ... and we are done.

palisis-juanra · 2025-05-22T11:48:18Z

src/TourCMS.php

-	public function get_last_request_headers() {
-		return $this->last_request_headers;
-	}
+        if (!is_null($tourId)) {


good to validate tour id if not null

palisis-juanra · 2025-05-22T11:48:30Z

src/TourCMS.php

+    {
+        $params = $this->validateParams($params);
+
+        if (!is_null($tourId)) {


palisis-juanra · 2025-05-22T11:49:51Z

src/TourCMS.php

+        return $this->request(self::PATH_API_C_TOURS_LOCATIONS . $params, $channel);
+    }
+
+    public function delete_tour(int $tourId, int $channel): SimpleXMLElement


good to validate tour id

palisis-manolo-ramos

Looking fine to me 👍🏻

TOURCMS-11047 Type methods parameters and returns, use consts and imp…

c08625e

…rove code

palisis-armando requested review from belen-palisis, jorgerodriguez-palisis, palisis-juancarlos and palisis-juanra May 9, 2025 12:22

palisis-armando self-assigned this May 9, 2025

palisis-juanra requested changes May 9, 2025

View reviewed changes

src/TourCMS.php Outdated Show resolved Hide resolved

src/TourCMS.php Outdated Show resolved Hide resolved

src/TourCMS.php Show resolved Hide resolved

src/TourCMS.php Show resolved Hide resolved

TOURCMS-11047 Restore create customer and verify customer methods and…

de1bec8

… remove isXMLObject method

palisis-armando requested a review from palisis-juanra May 9, 2025 12:51

TOURCMS-11047 Improve docs and use camelCase to name vars

b0bb45b

palisis-juanra requested changes May 9, 2025

View reviewed changes

src/TourCMS.php Outdated Show resolved Hide resolved

src/TourCMS.php Outdated Show resolved Hide resolved

src/TourCMS.php Outdated Show resolved Hide resolved

src/TourCMS.php Outdated Show resolved Hide resolved

TOURMCS-11047 Maintain return types and methods names

bb1cb47

palisis-armando requested a review from palisis-juanra May 12, 2025 06:38

palisis-juanra requested changes May 15, 2025

View reviewed changes

TOURCMS-11047 Use camelCase and improve naming

3497db0

palisis-armando requested a review from palisis-juanra May 19, 2025 11:44

TOURCMS-11047 Return response only as SimpleXMLElement and improve va…

0f3dfac

…lidation of tourId

belen-palisis reviewed May 22, 2025

View reviewed changes

jorgerodriguez-palisis approved these changes May 22, 2025

View reviewed changes

TOURCMS-11047 Fix extra empty lines and indentation

2180275

palisis-armando requested a review from belen-palisis May 22, 2025 07:49

belen-palisis approved these changes May 22, 2025

View reviewed changes

palisis-juanra requested changes May 22, 2025

View reviewed changes

TOURCMS-11047 Validate tourId

7916b41

palisis-armando requested a review from palisis-juanra May 28, 2025 11:11

palisis-juancarlos approved these changes Jul 2, 2025

View reviewed changes

palisis-juanra requested a review from palisis-manolo-ramos July 2, 2025 14:47

palisis-manolo-ramos approved these changes Jul 3, 2025

View reviewed changes

	public function set_user_agent(string $user_agent, bool $prepend = true): bool
	public function set_user_agent(string $userAgent, bool $prepend = true): bool

	public function update_tour($tour_data, int $channel): SimpleXMLElement\|string
	public function update_tour(SimpleXMLElement $tour, int $channel): SimpleXMLElement\|string

	return $this->request(self::PATH_API_TOUR_UPDATE, $channel, self::HTTP_VERB_POST, $tour_data);
	return $this->request(self::PATH_API_TOUR_UPDATE, $channel, self::HTTP_VERB_POST, $tour);


		public function search_voucher(SimpleXMLElement\|string\|null $voucherData = null, $channel = 0): SimpleXMLElement
		{


		public function add_note_to_booking(int $bookingId, int $channel, string $text, string $noteType): SimpleXMLElement
		{

TOURCMS-11047 Type methods parameters and returns, use consts and imp… #107

Are you sure you want to change the base?

TOURCMS-11047 Type methods parameters and returns, use consts and imp… #107

Uh oh!

Conversation

palisis-armando commented May 9, 2025

Uh oh!

palisis-juanra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

belen-palisis left a comment

Choose a reason for hiding this comment

Uh oh!

palisis-juanra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

palisis-manolo-ramos left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

7 participants