Skip to content

Change setting method of periodic execution to cronjob style #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
futabooo wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change setting method of periodic execution to cronjob style #49

futabooo wants to merge 3 commits into from
+99 −18

Conversation

@futabooo
Copy link
Contributor

@futabooo futabooo commented Nov 22, 2020

title is everything

@josh-burton
Copy link
Collaborator

josh-burton commented Nov 22, 2020

Thanks for the contribution! I think if we were to accept this change the usage of interval would have to remain but in a deprecated state. Otherwise this is a breaking change. Would you be able to make that change?

@futabooo
Copy link
Contributor Author

futabooo commented Nov 23, 2020

Thank you for your comment!
As you said, it has been a breaking change, so let's add an implementation that leaves the interval option.

@futabooo
Copy link
Contributor Author

futabooo commented Nov 24, 2020

@josh-burton I tried to leave the option of interval.

PeterDaveHello
PeterDaveHello reviewed Dec 16, 2020
View reviewed changes
appstorereviews.js Outdated
if (config.regions === false) {
try {
config.regions = JSON.parse(fs.readFileSync(__dirname + '/regions.json'));
config.regions = JSON.parse(fs.readFileSync(__dirname + '/regions.json'));
Copy link
Contributor

@PeterDaveHello PeterDaveHello Dec 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leaving the styling thing along will be better when implementing some functions? Otherwise the diff will including so many changes not related to the topic, make the review and code tracing a little bit harder.

It will be very great if the styling will be fixed with CI testing in another PR 👍

Copy link
Contributor Author

@futabooo futabooo Dec 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too. This PR undo unnecessary diffs 🙇

@futabooo futabooo force-pushed the cron-style-schedule branch from f3cb690 to c56c481 Compare December 20, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PeterDaveHello PeterDaveHello PeterDaveHello left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@futabooo @josh-burton @PeterDaveHello