Draft
Conversation
Member
Author
|
@hansgx Opened as Draft to start discussion on this 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert Theme structure from Typescript to JSON format.
This has 2 main advantages:
How it works?
We use JSON Schema to validate Theme JSON format.
However, since writing a JSON Schema can be lengthy and has a bit of a learning curve, we use Typescript to generate the JSON Schema. To do so, we use
typescript-json-schema.We also use
ajv-clito validate that JSON Theme files follow the defined shema. These tools are included in thebuildscript to make sure everything will work correctly.One possible improvement could be to be able to extend themes, a bit like before. For example, the base
lighttheme could contain all theme keys and values, whiledarktheme could only specify the values it wants to override from thelighttheme.