Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds new configuration options for SDK initialization to provide more granular control over data collection. The changes enhance the TSConfiguration interface with two new tracking flags while updating default behaviors and correcting documentation issues.
Changes:
- Added
enableTrackingNavigationDataandenableTrackingStaticDataconfiguration options - Changed default values from
falsetotruefor all tracking options - Fixed spelling error in README documentation ("whe" → "when")
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/index.tsx | Added two new optional boolean properties to TSConfiguration interface |
| ios/TsAccountprotection.swift | Updated iOS implementation to support new tracking options with true defaults |
| example/src/App.tsx | Updated example app to demonstrate all four tracking configuration options |
| RELEASE_NOTES.md | Added version 0.1.8 release notes documenting new features and 0.1.7 updates |
| README.md | Fixed typo, updated initialization method name, and added advanced configuration documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| componentDidMount(): void { | ||
| // Setup the module as soon your component is ready | ||
| await TSAccountProtectionSDKModule.initializeSDK(); | ||
| await TSAccountProtectionSDKModule.initializeSDKIOS(); |
There was a problem hiding this comment.
The method name initializeSDKIOS appears inconsistent with the method used elsewhere in the documentation. In the advanced configuration example below (line 106), the method is called initializeIOS. Consider using the same method name throughout the documentation for consistency.
| await TSAccountProtectionSDKModule.initializeSDKIOS(); | |
| await TSAccountProtectionSDKModule.initializeIOS(); |
There was a problem hiding this comment.
Both methods exists. This use is proper.
1 participant
Version 0.1.8
Enhanced Configuration Options
enableTrackingNavigationData: Control app navigation pattern tracking (default: true)enableTrackingStaticData: Control device/app static information tracking (default: true)truefor improved security coverageTSConfigurationinterface: Added support for the new tracking options while maintaining backward compatibility