MOB-2157 Fix for emailOTPAuthentication key mismatch in Android#7
MOB-2157 Fix for emailOTPAuthentication key mismatch in Android#7shachartransmit merged 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a key mismatch issue for email OTP authentication in the Android implementation. The Android native module was not properly mapping the journey step ID Transmit_platform_email_otp_authentication to the expected emailOTPAuthentication action type, preventing the feature from working correctly on Android devices.
Key Changes:
- Added Android mapping for the
Transmit_platform_email_otp_authenticationjourney step toemailOTPAuthentication - Implemented email OTP authentication handler with a new EmailOTPDialog component
- Updated example journey ID configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| android/src/main/java/com/tsidentityorchestration/TsIdentityOrchestrationModule.kt | Adds mapping for Android to convert platform-specific email OTP step ID to the expected action type |
| example/src/app/services/ido-service.ts | Implements email OTP authentication handler with dialog screen presentation |
| example/src/app/ido/screens/EmailOTPDialog.tsx | New React Native component providing UI for email OTP code entry |
| example/src/app/config.ts | Updates example journey ID to test the email OTP authentication flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| value={otp} | ||
| onChangeText={setOtp} | ||
| keyboardType="number-pad" | ||
| maxLength={6} |
There was a problem hiding this comment.
The 6-digit code length is hardcoded in multiple places (placeholder text on line 51 and maxLength here). Consider extracting this as a constant at the component level for easier maintenance if the OTP length requirements change.
|
Merging content to main. |
1 participant
No description provided.