Add support for K, W and C versions of NSMBW#8
Closed
RoadrunnerWMC wants to merge 1 commit intoTreeki:masterfrom
Closed
Add support for K, W and C versions of NSMBW#8RoadrunnerWMC wants to merge 1 commit intoTreeki:masterfrom
RoadrunnerWMC wants to merge 1 commit intoTreeki:masterfrom
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status of this PR
This PR has been split up and replaced by #13, #14, #15, and #16.
This PR adds support for the Korean (K), Taiwanese (W), and Chinese (C) releases of NSMBW to the dynamic loader (finished) and address map (work in progress).
Loader
The loader has been tested in Dolphin with the help of @Meatball132, and is verified working for all nine versions.
A few notes about the implementation:
800CF6CCis used as the primary identification test because it's the first of only about 30 DOL addresses that have statically unique values in 8 of the 9 versions. This was found through exhaustive search.80004238, which is the first address at which these two statically differ.Address map
(Work-in-progress)