Feature/shared element transition animation#26
Open
selimtoksal wants to merge 3 commits intoTrendyol:masterfrom
Open
Feature/shared element transition animation#26selimtoksal wants to merge 3 commits intoTrendyol:masterfrom
selimtoksal wants to merge 3 commits intoTrendyol:masterfrom
Conversation
TransitionAnimation
Create SharedElementSampleSecondFragment with image view Add image view to SampleFragment for shared element Add and create SharedElement class to FragmentData Add hasSharedElement control FragmentManagerController Implement shared element transition Add new start method for shared element data
bilgehankalkan
approved these changes
Nov 26, 2019
MertNYuksel
previously approved these changes
Nov 29, 2019
bilgehankalkan
approved these changes
Nov 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Add shared element transition animation
Motivation and Context
The library needed shared element transition animations
Transition animations offers a more beautiful experience
How Has This Been Tested?
Test normal transition animation for fragment start
Test shared element transition animation for fragment start
Screenshots (if appropriate):
Checklist: