-
Notifications
You must be signed in to change notification settings - Fork 2
Infra Cornerstone Work #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylelisk
wants to merge
16
commits into
TrustScience:main
Choose a base branch
from
kylelisk:klisk/aws-infra-cornerstone
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stuff because I like it :)
…stuff because I like it :)
…sks as well as HTTPS
Traffic now gets routed to the firewall subnets first and if it passes the checks it is then forwarded into the ALB subnets.
…the security scanning
- Added the network firewall logic and wired it all up with the routing - Network firewall logs to cloudwatch logs - Which then leads to the final piece of allowing cloudwatch logging for the network firewall; reused the ecs kms key for that
… specific CIDR ranges. Also cleaned up the README
1. Circular dependencies of security group rules between ALB and ECS 2. Network security group rules have a peculiar issue with AWS and needed a 'settings' variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes related to creating all of the terraform for the infrastructure as well as pipelines.