Reflect multi-version compatibility in source file names#157
Reflect multi-version compatibility in source file names#157paultcochrane wants to merge 1 commit intoTurbo87:masterfrom
Conversation
This change implements the suggestion mentioned in Turbo87#156 to rename the source files from `ol3` to simply `ol` so as to reflect the compatibility from OpenLayers 3 up to and including OpenLayers 6. The example file as well as the documentation have been updated to be consistent with the filename generalisation.
|
hmm, I guess we would have to consider this a breaking change because the files are no longer available at the old paths 🤔 |
|
Hrm, true. Hadn't thought about that aspect. If you don't consider the patch to be merge-worthy, I'm totally ok with it :-) I saw the suggestion and thought that it might be helpful. As I was thinking about your comment I had a thought: is anyone still using OpenLayers 2? I mean, are the |
|
Come to think of it: surely if a user depends upon this filename then they will be using a very old version of OpenLayers anyway and can thus specify version 0.4.0 of sidebar-v2 in order to maintain the expected functionality. What do you think? |
2 participants
This change implements the suggestion mentioned in #156 to rename the
source files from
ol3to simplyolso as to reflect thecompatibility from OpenLayers 3 up to and including OpenLayers 6.
The example file as well as the documentation have been updated to be
consistent with the filename generalisation.
Please review these changes! I've checked that the example works, but it's still possible that I might have missed something as part of the renaming process.
If you'd like anything changed or want this commit split into multiple commits or whatever, please don't hesitate to let me know!