fix(frontend): resolve SSE warnings, add ETA, and prevent DOM errors in full_techniques mode #272
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -155,6 +155,22 @@ export const useEvaluationStream = (evaluationId: string): UseEvaluationStreamRe | |
| case 'error': | ||
| break; | ||
|
|
||
| // Full techniques mode events - handled by useFullTechniquesStream | ||
| // Silently ignore here to prevent console warnings | ||
| case 'technique_start': | ||
| case 'technique_complete': | ||
| case 'technique_error': | ||
| case 'category_start': | ||
| case 'category_complete': | ||
| case 'deep_synthesis_start': | ||
| case 'deep_synthesis_complete': | ||
| case 'quality_gate_complete': | ||
| case 'enrichment_start': | ||
| case 'enrichment_complete': | ||
| case 'enrichment_error': | ||
| case 'metrics_update': | ||
| break; | ||
|
|
||
| default: | ||
| console.warn('Unknown event type:', eventType); | ||
| } | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -89,6 +89,8 @@ const INITIAL_CATEGORIES: Record<string, CategoryStatus> = Object.entries(CATEGO | |
| {} | ||
| ); | ||
|
|
||
| const ESTIMATED_TOTAL_SECONDS = 600; | ||
|
|
||
| const initialState: FullTechniquesStreamState = { | ||
| connectionStatus: 'connecting', | ||
| retryCount: 0, | ||
|
|
@@ -103,6 +105,8 @@ const initialState: FullTechniquesStreamState = { | |
| isComplete: false, | ||
| tokensUsed: 0, | ||
| costUsd: 0, | ||
| startedAt: new Date().toISOString(), | ||
|
There was a problem hiding this comment.
To fix this, Since a code suggestion cannot span multiple parts of the file, here is an example of how you could implement this: // 1. Create a function to generate the initial state
const createInitialState = (): FullTechniquesStreamState => ({
// ... other initial state properties from your existing initialState object
startedAt: new Date().toISOString(),
etaSeconds: ESTIMATED_TOTAL_SECONDS,
});
// 2. Use this function for lazy initialization in the hook
const [state, dispatch] = useReducer(reducer, undefined, createInitialState);
// 3. Use the function in your reducer's RESET case
case 'RESET':
return createInitialState(); |
||
| etaSeconds: ESTIMATED_TOTAL_SECONDS, | ||
| enrichmentPhase: 'idle', | ||
| enrichmentMessage: null, | ||
| enrichmentStatus: { | ||
|
|
@@ -116,7 +120,8 @@ type Action = | |
| | { type: 'CONNECTION_CHANGE'; status: FullTechniquesStreamState['connectionStatus']; retryCount?: number } | ||
| | { type: 'EVENT_RECEIVED'; event: SSEEvent } | ||
| | { type: 'ERROR'; error: string } | ||
| | { type: 'RESET' } | ||
| | { type: 'UPDATE_ETA'; elapsedSeconds: number }; | ||
|
|
||
| function reducer(state: FullTechniquesStreamState, action: Action): FullTechniquesStreamState { | ||
| switch (action.type) { | ||
|
|
@@ -334,6 +339,23 @@ function reducer(state: FullTechniquesStreamState, action: Action): FullTechniqu | |
| return newState; | ||
| } | ||
|
|
||
| case 'UPDATE_ETA': { | ||
| if (state.isComplete || state.completedTechniques === 0) { | ||
| return state; | ||
| } | ||
|
|
||
| const { elapsedSeconds } = action; | ||
| const completionRatio = state.completedTechniques / state.totalTechniques; | ||
|
|
||
| if (completionRatio > 0 && completionRatio < 1) { | ||
| const estimatedTotalTime = elapsedSeconds / completionRatio; | ||
| const remainingSeconds = Math.max(0, Math.ceil(estimatedTotalTime - elapsedSeconds)); | ||
| return { ...state, etaSeconds: remainingSeconds }; | ||
| } | ||
|
|
||
| return state; | ||
| } | ||
|
|
||
| default: | ||
| return state; | ||
| } | ||
|
|
@@ -427,5 +449,18 @@ export function useFullTechniquesStream(evaluationId: string | null) { | |
| }; | ||
| }, [evaluationId, state.isComplete, token]); | ||
|
|
||
| useEffect(() => { | ||
| if (!evaluationId || state.isComplete) return; | ||
|
|
||
| const startTime = state.startedAt ? new Date(state.startedAt).getTime() : Date.now(); | ||
|
|
||
| const interval = setInterval(() => { | ||
| const elapsedSeconds = Math.floor((Date.now() - startTime) / 1000); | ||
| dispatch({ type: 'UPDATE_ETA', elapsedSeconds }); | ||
| }, 5000); | ||
|
|
||
| return () => clearInterval(interval); | ||
| }, [evaluationId, state.isComplete, state.startedAt]); | ||
|
|
||
| return state; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition to check the current stage is repeated and a bit long. For better readability and maintainability, you can use an array and the
includesmethod. This also makes it easier to add more stages in the future.