feat: add fuzzy searching for log group names#72
Open
a-h wants to merge 5 commits intoTylerBrock:masterfrom
Open
feat: add fuzzy searching for log group names#72a-h wants to merge 5 commits intoTylerBrock:masterfrom
a-h wants to merge 5 commits intoTylerBrock:masterfrom
Conversation
Owner
|
very nice -- I will take a look when I get some time to do so, thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you're building Lambda functions with CDK, you can't always guess the log prefix, and even if you can, it's a bit unweildy.
For example, with a CDK stack with logical ID "NodeCountExampleAwsLambdaStack" and a Lambda function called "CountGetFunction", CDK generates a CloudWatch Log Group of:
Note how "NodeCountExampleAwsLambdaStack" is truncated to "NodeCountExampleAwsLambda". There are also limits on the function logical ID.
To save me from having to use
saw groups | grep CountGet, then copy / paste the outputted group name so that I can runsaw get <groupname>, I thought it would be helpful to be able to "fuzzy search" the group name.So in this PR, I've implemented a basic "contains substring" search for the log group that's only triggered when a
--fuzzyflag is set.You can get the logs directly with:
Compared to:
Obviously, it costs a CloudWatch Log API call or two if you use the fuzzy search flag, but it's not the default behaviour so won't affect anyone that doesn't use it.