refactor: increase plugin timeout #41
Conversation
There was a problem hiding this comment.
Pull request overview
This PR increases the plugin timeout from the default value to 5 minutes (300,000 milliseconds) to accommodate slow service startups when multiple services are launched simultaneously, such as via docker compose up.
- Added a hardcoded
pluginTimeoutconfiguration of 5 minutes to the Fastify options - Included explanatory comments describing the rationale for the increased timeout
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // This increases the timeout for plugins to 5 minutes. | ||
| pluginTimeout: 5 * 60 * 1000, |
There was a problem hiding this comment.
[nitpick] The plugin timeout is hardcoded to 5 minutes. Consider making this configurable via an environment variable (e.g., PLUGIN_TIMEOUT) to allow for flexibility across different deployment environments without requiring code changes. This follows the pattern already established in the codebase with other configuration options like AUTH_DISCOVERY_URL and AUTH_CLIENT_ID.
Example:
pluginTimeout: parseInt(getOption("PLUGIN_TIMEOUT", false) || "300000", 10),| // This increases the timeout for plugins to 5 minutes. | |
| pluginTimeout: 5 * 60 * 1000, | |
| // This increases the timeout for plugins to 5 minutes, or can be overridden with PLUGIN_TIMEOUT env var. | |
| pluginTimeout: parseInt(getOption("PLUGIN_TIMEOUT", false) || "300000", 10), |
No description provided.