feat: add model settings id parameter #1053
Open
+450
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
test:uipath-langchain
cristipufu
reviewed
Dec 27, 2025
src/uipath/_cli/_evals/_runtime.py
Outdated
| logger.warning(f"Model settings ID '{self.context.model_settings_id}' not found in evaluation set") | ||
| return None | ||
|
|
||
| console.info(f"Found model settings: model='{target_model_settings.model_name}', temperature='{target_model_settings.temperature}'") |
Member
There was a problem hiding this comment.
Please use logger, console is a CLI concept (imagine we extract the evals engine to another library)
src/uipath/_cli/_evals/_runtime.py
Outdated
| return None | ||
|
|
||
| # Load the original entrypoint file | ||
| entrypoint_path = Path(self.context.entrypoint or "agent.json") |
Member
There was a problem hiding this comment.
We shouldn't leak agent.json concepts here .. similar comment: #1048 (review)
Collaborator
There was a problem hiding this comment.
+1.
The other PR uses protocols to break this. Maybe we need to update the protocol method to return EvaluationSetModelSettings instead of model_name.
akshaylive
reviewed
Dec 30, 2025
| max_tokens: int | None = Field(default=None, alias="maxTokens") | ||
|
|
||
|
|
||
| class EvaluationSetModelSettings(BaseModel): |
Collaborator
There was a problem hiding this comment.
Should we reuse ModelSettings instead? EvaluationSetModelSettings seems to be a subset of ModelSettings, so it should be forward-compatible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development Package
uipath pack --nolockto get the latest dev build from this PR (requires version range).