Skip to content

close producer when kafka-producer-actor terminates #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachary-rote wants to merge 3 commits into
base: main
Choose a base branch
from
Open

close producer when kafka-producer-actor terminates #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b028660
close producer when kafka-producer-actor terminates
zachary-rote May 4, 2023
b32e6bd
change formatting
zachary-rote May 4, 2023
6cb7560
expect atleast one close
zachary-rote May 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/command-engine/core/src/main/scala/surge/internal/kafka/KafkaProducerActorImpl.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ class KafkaProducerActorImpl(
flushMessagesScheduledTask.cancel()
checkKTableLagScheduledTask.cancel()
clearExpiredTrackersScheduledTask.cancel()
kafkaPublisher.close()
super.postStop()
}

Expand Down
17 changes: 16 additions & 1 deletion .../command-engine/core/src/test/scala/surge/internal/kafka/KafkaProducerActorImplSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import surge.health.domain.EmittableHealthSignal
import surge.internal.akka.cluster.ActorSystemHostAwareness
import surge.internal.akka.kafka.{ KafkaConsumerPartitionAssignmentTracker, KafkaConsumerStateTrackingActor }
import surge.internal.health.{ HealthCheck, HealthCheckStatus }
import surge.internal.kafka.KafkaProducerActorImpl.{ KTableProgressUpdate, PublishTrackerStateManager, SenderWithTrackingId }
import surge.internal.kafka.KafkaProducerActorImpl.{ KTableProgressUpdate, PublishTrackerStateManager, SenderWithTrackingId, ShutdownProducer }
import surge.kafka._
import surge.internal.health.HealthyActor.GetHealth
import surge.kafka.streams.ExpectedTestException
Expand Down Expand Up @@ -678,6 +678,21 @@ class KafkaProducerActorImplSpec
probe.expectMsgClass(classOf[PublishSuccess])
verify(mockProducerFenceOnCommit).putRecords(records(testMessages2))
}

"Close Kafka Producer on Shutdown" in {
val probe = TestProbe()
val mockPartitionTracker = mock[KafkaConsumerPartitionAssignmentTracker]
val mockProducer = mock[GenericKafkaProducer[String, Array[Byte]]]

val mockLagChecker = mockKTableLagChecker(assignedPartition, 100L, 100L)
val producerActorToShutdown =
testProducerActor(assignedPartition, mockProducer, mockLagChecker, new PublishTrackerStateManager(), mockPartitionTracker)

// Send Shutdown Command
probe.send(producerActorToShutdown, ShutdownProducer)

verify(mockProducer, Mockito.timeout(1000).atLeast(1)).close()
}
}

"KafkaProducerActorState" should {
Expand Down