Open
Conversation
Contributor
Author
|
@Scriptminer looks good - wonder if you could do without the temp files but not a deal breaker. |
Contributor
Author
|
@Scriptminer could you add something at the top of the file to indicate that these files are provided to be helpful but students should use this at their own risk etc etc and then will merge |
Scriptminer
force-pushed
the
aidan-scripts
branch
from
0ba671f to
9696d50
Compare
Collaborator
|
Thanks for looking over them @andeElliott ! I've added the "use at own risk" information now. I looked into avoiding using temp files, but looks like it would require significant rewriting, which is probably not worth it given these scripts aren't likely to be widely used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.